Use the correct class for until in the github plugin - #405
Merged
Conversation
Fix regression introduced in #376. The `until` date should use the `did.base.Date` class. Otherwise stats like commented issues traceback because of the missing `datetime` attribute. Include a basic sanity coverage which exercises all stats to prevent similar issues in the future.
Owner
Author
|
For reference, this is the traceback: File "/home/psss/git/did/did/stats.py", line 76, in check
self.fetch()
~~~~~~~~~~^^
File "/home/psss/git/did/did/plugins/github.py", line 279, in fetch
commented_issues, since.datetime, until.datetime, login
^^^^^^^^^^^^^^
AttributeError: 'datetime.date' object has no attribute 'datetime' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in #376. The
untildate should use thedid.base.Dateclass. Otherwise stats like commented issues traceback because of the missingdatetimeattribute. Include a basic sanity coverage which exercises all stats to prevent similar issues in the future.