Fix issue with wrong until in GitHub search - #376
Conversation
|
Thanks for fixing this! Would you mind extending the /tests/github/issues and /tests/github/pulls tests with a simple test case demonstrating that the dates now work as expected? |
|
The PRs and issues appearing when running tests against the master: teemtee/tmt#1645, teemtee/tmt#1644, teemtee/tmt#1648, teemtee/tmt#1650 |
eb67936 to
6a1a32f
Compare
|
It was previously inconsistent with using somewhere defined local variables and somewhere not. Fixed it |
|
This PR is ready to review and merge. Since it touches the same code, I'll use it as a base for #363. |
|
Hey-hey, happy new year! A kind ping? |
|
Can you please rebase? |
|
It looks like it is still working, and all tests have passed. |
7315f15 to
1305b75
Compare
|
I see. I have not installed tenacity, so my isort considered it a local package. Didn't know the codebase applied I prefer |
473f4b5 to
b1c63e4
Compare
82f382f to
be1dd51
Compare
|
Good to go? |
be1dd51 to
de47e9e
Compare
Fix regression introduced in #376. The `until` date should use the `did.base.Date` class. Otherwise stats like commented issues traceback because of the missing `datetime` attribute. Include a basic sanity coverage which exercises all stats to prevent similar issues in the future.
Fix regression introduced in #376. The `until` date should use the `did.base.Date` class. Otherwise stats like commented issues traceback because of the missing `datetime` attribute. Include a basic sanity coverage which exercises all stats to prevent similar issues in the future.
It fixes #362.
A decoupled part from #363