Fix until returning type - #404
Closed
sandrobonazzola wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
@Felixoid can you please review? |
Collaborator
Author
|
without this change I see: did/plugins/github.py", line 281, in fetch
commented_issues, since.datetime, until.datetime, login
^^^^^^^^^^^^^^
AttributeError: 'datetime.date' object has no attribute 'datetime' |
GitHub.until needs to return did.base.Date instead of datetime.date Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
date_until_fix
branch
from
June 3, 2025 14:18
62564e0 to
f227dd6
Compare
Contributor
|
Let me see. I remember the idea of |
Owner
|
Ah, sorry, was so focused on finishing the last items before the release that I haven't noticed this one. Completely agree with the fix. I've covered this in #405 together with extending the test coverage a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub.until needs to return did.base.Date instead of datetime.date