This repository was archived by the owner on Jan 5, 2024. It is now read-only.
View controller removal bug#23
Merged
6 commits merged intoNov 20, 2018
Merged
Conversation
Contributor
|
If we only call removeFromSuperview on the view controllers view, the 'padding view' will remain in the view hierarchy. arrangedView.removeFromSuperview() will take care of it all, including removing arrangedView from arrangedSubviews. |
removeFromSuperview also removes the view from the arrangedSubviews array, so that call is no longer needed.
Contributor
|
@edrutter-je would appreciate it if you gave this a wee once over :) |
Contributor
Author
|
LGTM |
This was referenced Nov 20, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where a ViewController's view was not removed from it's superview when calling remove(viewController: UIViewController) if it was embedded in a 'padding view'.