Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Swift4.2#22

Merged
2 commits merged into
justeat:masterfrom
vkaramov:swift4.2
Dec 4, 2018
Merged

Swift4.2#22
2 commits merged into
justeat:masterfrom
vkaramov:swift4.2

Conversation

@vkaramov

Copy link
Copy Markdown
Contributor

Swift 4.2 support

@ghost

ghost commented Nov 9, 2018

Copy link
Copy Markdown

Hi @vkaramov thanks a lot for contributing, this is really valuable to us.
Errors are due to CI using Xcode 9 and previous version of swift. We have plans to migrate to Xcode 10 and 4.2 across all our modules in ~ month time before the end of the year. Until that time we'd like to avoid exceptions in both code and stack configuration.
Please stay tuned and again, thanks a lot for your PR!

@vkolosovsky

Copy link
Copy Markdown

@albertodebortoli Do you have plans to release 4.2 support in the mean time?

@ghost ghost mentioned this pull request Dec 4, 2018
3 tasks
@ghost ghost merged commit b13ef1f into justeat:master Dec 4, 2018
@ghost

ghost commented Dec 4, 2018

Copy link
Copy Markdown

Hi @vkolosovsky, we just did for you!

This PR included two changes: 1. support for swift 4.2 and 2. attempt to fix a bug that was already sorted (in a differ way) with #23.

We created #24 with the 2 commits from this PR plus other minor details and published version 4.1.0 to the master repo. Closing this one.

Thanks @vkaramov for contributing!

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants