Skip to content

Ensures Visual C++ Redistributables for 2013 is installed - #757

Merged
davidmfinol merged 1 commit into
game-ci:mainfrom
lupidan:fix/EnsureVcredist13IsInstalled
Nov 2, 2025
Merged

Ensures Visual C++ Redistributables for 2013 is installed#757
davidmfinol merged 1 commit into
game-ci:mainfrom
lupidan:fix/EnsureVcredist13IsInstalled

Conversation

@lupidan

@lupidan lupidan commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Adds a script to make sure Visual C++ Redistributables 2013 is installed in the machine, so Unity.exe can be launched
  • Calls said method from entrypoint.ps1

Notes

I wasn't able to detect the 2013 Redistributables being present in the current windows-latest github runner image. But they specify that those should be available in the image.
I am suspecting there might be an issue with the current runner image for windows 🤔

In any case, this should solve the issue for now until a better fix is found

These are the redistributables I can find in when running on windows-latest

Checking installed Visual C++ Redistributables via registry
----
DisplayName    : Microsoft Visual C++ 2015-2022 Redistributable (x64) - 
                 14.38.33135
DisplayVersion : 14.38.33135.0
----
DisplayName    : Microsoft Visual C++ 2015-2022 Redistributable (x86) - 
                 14.38.33135
DisplayVersion : 14.38.33135.0
----
DisplayName    : Microsoft Visual C++ 2022 X64 Additional Runtime - 14.38.33135
DisplayVersion : 14.38.33135
----
DisplayName    : Microsoft Visual C++ 2022 X64 Minimum Runtime - 14.38.33135
DisplayVersion : 14.38.33135
----
DisplayName    : Microsoft Visual C++ 2022 X86 Additional Runtime - 14.38.33135
DisplayVersion : 14.38.33135
----
DisplayName    : Microsoft Visual C++ 2022 X86 Minimum Runtime - 14.38.33135
DisplayVersion : 14.38.33135

Successful Workflow Run Link

It's not fully successful, but you can see the Activation and Build did finish in this repo of a plugin I maintain

@coderabbitai

coderabbitai Bot commented Oct 22, 2025

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • dist/platforms/windows/entrypoint.ps1 is excluded by !**/dist/**
  • dist/platforms/windows/install_vcredist13.ps1 is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Cat Gif

@davidmfinol

Copy link
Copy Markdown
Member

One concern: If Visual C++ Redistributables 2013 is already installed on the machine (for example, by self-hosted runners that don't rely on the GitHub runner images), would Chocolately cause any issue? I think ideally choco install vcredist2013 -y --no-progress would detect that it's already installed and therefore do nothing, but can we get confirmation to not potentially break for self-hosted runners?

@davidmfinol
davidmfinol merged commit 3a2abf9 into game-ci:main Nov 2, 2025
4 checks passed
@lupidan

lupidan commented Nov 2, 2025

Copy link
Copy Markdown
Contributor Author

Just saw the merge. Maybe we can iterate on this idea to make the solution even better.
I want to check again windows-latest on github actions, maybe images are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants