binary-search-tree : add test template#2157
Merged
cmccandless merged 8 commits intoJan 14, 2020
Merged
Conversation
cmccandless
suggested changes
Jan 13, 2020
cmccandless
left a comment
Contributor
There was a problem hiding this comment.
A couple of things:
- You seem to be mixing template variables with Python variables. The rendered test code will not have access to variables like
caseor macros declared in the template (i.e.test_call) - I noticed you were having difficulty with subcase groups nested with actual test cases (exercism/problem-specifications#1629). The proper way to deal with this in the template is to check for the
casesfield in thecaseobject, and handle it accordingly.
With the above in mind, please see my refactored version here.
Contributor
|
Feel free to duplicate my changes if you wish. If you would like to use my commit directly:
|
…mplate fix template to generate all tests, refactor for readability
Contributor
Author
|
@cmccandless I did that you say, the branch is ready for commit! |
cmccandless
approved these changes
Jan 14, 2020
cmccandless
left a comment
Contributor
There was a problem hiding this comment.
My apologies, my fix had an error that created an extra blank line. I determined I had the necessary permissions and took the liberty of pushing the fix myself.
tsamoglou
added a commit
to tsamoglou/python
that referenced
this pull request
Jan 15, 2020
binary-search-tree : add test template (exercism#2157)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.