Skip to content

Modify DA Test to use SubmitBlocks with multiple blocks#1085

Merged
Manav-Aggarwal merged 10 commits into
mainfrom
manav/submit_blocks_add_da_test
Aug 9, 2023
Merged

Modify DA Test to use SubmitBlocks with multiple blocks#1085
Manav-Aggarwal merged 10 commits into
mainfrom
manav/submit_blocks_add_da_test

Conversation

@Manav-Aggarwal

@Manav-Aggarwal Manav-Aggarwal commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Overview

Closes: #1086

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Manav-Aggarwal Manav-Aggarwal linked an issue Jul 18, 2023 that may be closed by this pull request
Modify DA Test to use SubmitBlocks with multiple blocks #1086
Closed
@Manav-Aggarwal Manav-Aggarwal changed the base branch from main to manav/modify_da_interface_submit_blocks July 18, 2023 20:35
@codecov

codecov Bot commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@58ab158). Click here to learn what that means.
Patch coverage: 35.29% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage        ?   55.93%           
=======================================
  Files           ?       61           
  Lines           ?     6572           
  Branches        ?        0           
=======================================
  Hits            ?     3676           
  Misses          ?     2503           
  Partials        ?      393
Files Changed Coverage Δ
types/serialization.go 61.00% <35.29%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manav-Aggarwal Manav-Aggarwal mentioned this pull request Jul 18, 2023
Merged
5 tasks
Base automatically changed from manav/modify_da_interface_submit_blocks to main July 19, 2023 13:19
@gupadhyaya gupadhyaya force-pushed the manav/submit_blocks_add_da_test branch from 5d4327b to 10c0d61 Compare August 2, 2023 01:50
@gupadhyaya gupadhyaya marked this pull request as ready for review August 2, 2023 17:37
@gupadhyaya gupadhyaya enabled auto-merge August 2, 2023 22:28
@nashqueue nashqueue requested review from tuxcanfly and tzdybal August 7, 2023 17:19
gupadhyaya
gupadhyaya previously approved these changes Aug 8, 2023
View reviewed changes
tuxcanfly
tuxcanfly previously approved these changes Aug 8, 2023
View reviewed changes

@tuxcanfly tuxcanfly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@gupadhyaya gupadhyaya added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
nashqueue
nashqueue reviewed Aug 8, 2023
View reviewed changes

@nashqueue nashqueue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment thread da/test/da_test.go
@Manav-Aggarwal Manav-Aggarwal dismissed stale reviews from tuxcanfly and gupadhyaya via f217d97 August 9, 2023 03:36
nashqueue
nashqueue approved these changes Aug 9, 2023
View reviewed changes

@nashqueue nashqueue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gupadhyaya gupadhyaya self-requested a review August 9, 2023 11:16
@Manav-Aggarwal Manav-Aggarwal added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit ad8190c Aug 9, 2023
@Manav-Aggarwal Manav-Aggarwal deleted the manav/submit_blocks_add_da_test branch August 9, 2023 11:22
Manav-Aggarwal added a commit that referenced this pull request Sep 6, 2023
@Manav-Aggarwal
Modify DA Test to use SubmitBlocks with multiple blocks (#1085)
0d4ce70 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: #1086 

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

---------

Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuxcanfly tuxcanfly tuxcanfly left review comments

@MSevey MSevey Awaiting requested review from MSevey

@tzdybal tzdybal Awaiting requested review from tzdybal

+2 more reviewers

@gupadhyaya gupadhyaya gupadhyaya approved these changes

@nashqueue nashqueue nashqueue approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Manav-Aggarwal Manav-Aggarwal

Labels

C:block-sync T:testing Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify DA Test to use SubmitBlocks with multiple blocks

4 participants

@Manav-Aggarwal @tuxcanfly @gupadhyaya @nashqueue