Modify SubmitBlock to SubmitBlocks in DA interace#1083
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 55.61% 55.60% -0.01%
==========================================
Files 63 63
Lines 6799 6800 +1
==========================================
Hits 3781 3781
- Misses 2606 2607 +1
Partials 412 412
☔ View full report in Codecov by Sentry. |
gupadhyaya
reviewed
Jul 18, 2023
gupadhyaya
reviewed
Jul 18, 2023
gupadhyaya
left a comment
Contributor
There was a problem hiding this comment.
generally looks good. just needs an additional test for multiple block submission and retrieve imo.
tzdybal
approved these changes
Jul 19, 2023
tzdybal
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I think that as follow up issue we can think about improving error messages (because there's no way to know which block failed).
gupadhyaya
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves: #1080, #1084
Adding DA Testing PR WIP: #1086
Checklist