Problem/Motivation

Subqueues should be able to be included in modern Drupal workflows, like Content Moderation, Content Translation, Workspaces, etc.

In order to do that, the entity_subqueue needs to be revisionable, translatable and publishable.

This is the last item that prevents an RC (and stable) release for this module :)

Proposed resolution

Drupal 8.7.0 introduced a new Entity Update API which allows us to convert entity type schema even when they have existing data, so we have to require a specific core version in order to this conversion safely.

Remaining tasks

Review/commit.

User interface changes

None yet. Adding a revision UI will be done in #2952938: Add a revision UI for subqueues.

API changes

None.

Data model changes

Subqeueus are now revisionable, translatable and publishable.

CommentFileSizeAuthor
#2 3058127.patch19.1 KBamateescu

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 3058127.patch19.1 KB

Here's an initial patch for this. Tested manually and the upgrade path works really well.

  • amateescu committed e099b13 on 8.x-1.x 
    Issue #3058127 by amateescu, Spec0, Roensby, Etroid: Convert subqueues...

amateescu credited Etroid.

amateescu credited Roensby.

amateescu credited Spec0.

amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Adding credit to all the people who worked on #2952938: Add a revision UI for subqueues and #2850409: Multilingual functionality, and committed to 8.x-1.x!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

validoll’s picture

validoll commented

Hello.

Sorry for writing to closed issue, but I see `Translation is not supported` for Entity subqueue on Content language settings page.

What did I miss?

validoll’s picture

validoll commented

I found that links to translations were not added due to lack of "canonical" link.
Entity subqueue can't be translated now.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3128057: Error updating to v1.0

not only that, this appears to break upgrading for us from beta5

I am still investigating.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

On beta5 we're fine

as soon as I advance one commit to this , no longer able to run updb

here is the error:

[error]  Exception thrown while performing a schema update. SQLSTATE[42S02]: Base table or view not found: 1146 Table 'MYSCHEMA.entity_subqueue__scheduled_transition_date' doesn't exist: SELECT t.* FROM {entity_subqueue__scheduled_transition_date} t
amateescu’s picture

amateescu commented

@validoll, the translation problem was fixed in #3073147: Subqueues are still not translatable in the UI.

@joseph.olstad, the upgrade problem is caused by #3126343: Scheduler needs to maintain its base fields properly.