Problem/Motivation

I've been looking for a way to have a Nodequeue-like Entity Reference widget. Someone on IRC mentioned that this module has a widget that is really close to what I'm looking for (and would only require a slight modification for the publishing status. However, I don't need the rest of Entity Queue. :/

Proposed resolution

Move the "Draggable Table" Entity Reference widget into a submodule of this module (same project) and allow it to be installed independently of Entity Queue.

CommentFileSizeAuthor
#1 dragtable-2460503-1.patch27.13 KBdavidwbarratt
#2 dragtable-2460503-2.patch27.13 KBdavidwbarratt
#4 dragtable-2460503-4.patch27.16 KBdavidwbarratt
#5 dragtable-2460503-5.patch26.62 KBdavidwbarratt
#5 interdiff-2460503-4-5.txt889 bytesdavidwbarratt

Comments

davidwbarratt’s picture

davidwbarratt commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new dragtable-2460503-1.patch27.13 KB

Attached is a patch that moves the field formatter into a submodule of Entityqueue.

davidwbarratt’s picture

davidwbarratt commented
StatusFileSize
new dragtable-2460503-2.patch27.13 KB

Fixed a typo in a function name.

jojonaloha’s picture

jojonaloha commented
Status: Needs review » Needs work

I think this is a good idea, and thought about doing this originally, but if I remember there were a few things I had a hard time separating.

Anyway, so far the patch looks good, but I notice the Reverse, Shuffle and Clear buttons don't function the way they did before. It seems they do take effect after you hit Save, but you don't get to preview the changes or know that it did anything. I think it's just that the ajax replacement of the form isn't happening anymore.

davidwbarratt’s picture

davidwbarratt commented
StatusFileSize
new dragtable-2460503-4.patch27.16 KB

Rerolled patch.

I'll look into why the buttons are no longer working, I may have moved/removed something that was needed.

davidwbarratt’s picture

davidwbarratt commented
Status: Needs work » Needs review
StatusFileSize
new dragtable-2460503-5.patch26.62 KB
new interdiff-2460503-4-5.txt889 bytes

Yep, looks like I accidentally removed the Ajax callback, I've added it back in this patch.

davidwbarratt’s picture

davidwbarratt commented
albertski’s picture

albertski commented
Status: Needs review » Needs work

This patch is failing:

curl https://www.drupal.org/files/issues/dragtable-2460503-5.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27260  100 27260    0     0  38783      0 --:--:-- --:--:-- --:--:-- 38776
patching file entityqueue.info
patching file entityqueue.module
Hunk #1 succeeded at 679 (offset -2 lines).
Hunk #2 FAILED at 836.
1 out of 2 hunks FAILED -- saving rejects to file entityqueue.module.rej
patching file includes/entityqueue.theme.inc
patching file js/entityqueue.widget.js
patching file modules/entityqueue_dragtable/entityqueue_dragtable.info
patching file modules/entityqueue_dragtable/entityqueue_dragtable.module
patching file modules/entityqueue_dragtable/includes/entityqueue.theme.inc
patching file modules/entityqueue_dragtable/js/entityqueue_dragtable.widget.js
jenlampton’s picture

jenlampton
she / her
commented

+1 for moving into another module. I am using entityqueue on several sites and some more jr developers keep using the super-buggy 'Draggable table' widget when it's completely unnecessary. I'd love to get rid of it until it stabilizes, it will keep my client complaints down :)

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented

+1 for this in D8, the widget is useful outside of entityqueue too.