Add gitattributes, skip bundling build artifacts in released package - #62
Merged
Conversation
Ocramius
approved these changes
Mar 7, 2024
Ocramius
left a comment
Contributor
There was a problem hiding this comment.
Thanks @VincentLanglet!
|
@VincentLanglet do you remember why composer.lock file has not been ignored same way? Our CVE tool Trivy scan all composer.lock files in |
Contributor
Author
|
I would say first that the CVE tool is wrong to scan the composer.lock in the vendor folder since it's not used when you install a library. Also I often add the lock file in the gitignore file rather than just the gitattributes ; but you can still provide a pr to add it in the gitattributes if you want to |
Contributor
|
From a library PoV, working with unlocked dependencies has proven to be a long-term disaster, especially since libraries like Symfony straight out lie about supported dependency ranges 😱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Seems like this project is missing
.gitattributesfile so I tried to add one.