FEATURE: add $skipErrors option to GlobIterator - #61
Merged
Conversation
Ocramius
suggested changes
May 17, 2022
Ocramius
left a comment
Contributor
There was a problem hiding this comment.
Requires an automated test to validate the behavior of the new flag and prevent regressions long-term.
Contributor
Author
|
I can imagine hacking something for linux based tests. chmod-ing a directory and so causing an access error... |
Contributor
|
Yup, pretty much what is needed 👍 |
Contributor
Author
|
Added a test also. Amazingly, I managed to screw up the RecursiveIteratorIterator flag (because I copied the code around so much) and the test caught it :) |
Ocramius
suggested changes
May 17, 2022
Ocramius
left a comment
Contributor
There was a problem hiding this comment.
Tests currently failing 😁
Contributor
Author
|
Now the only other change I can think of is exposing $skipErrors to |
Ocramius
suggested changes
May 24, 2022
Ocramius
approved these changes
May 24, 2022
$skipErrors option to GlobIterator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.