Skip to content

Support running under alpine and musl-based environments: use GLOB_BRACE only when defined - #29

Merged
Ocramius merged 8 commits into
webmozarts:4.3.xfrom
Firehed:4.3.x
Jan 21, 2021
Merged

Support running under alpine and musl-based environments: use GLOB_BRACE only when defined#29
Ocramius merged 8 commits into
webmozarts:4.3.xfrom
Firehed:4.3.x

Conversation

@Firehed

@Firehed Firehed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor

Fixes #15

@Firehed

Firehed commented Jan 20, 2021

Copy link
Copy Markdown
Contributor Author

I saw an equivalent linked PR that stated tests need to run on Alpine too. I'll look into it.

@Ocramius Ocramius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius changed the title Only use GLOB_BRACE when defined Support running under alpine and musl-based environments: use GLOB_BRACE only when defined Jan 21, 2021
@Ocramius Ocramius self-assigned this Jan 21, 2021
@Ocramius Ocramius added this to the 4.3.0 milestone Jan 21, 2021
@Ocramius
Ocramius merged commit 06358fa into webmozarts:4.3.x Jan 21, 2021
@Ocramius

Copy link
Copy Markdown
Contributor

Excellent work, @Firehed! Thanks!

@Ocramius Ocramius added the bug label Jan 21, 2021
@stof

stof commented Jan 21, 2021

Copy link
Copy Markdown

what happens for globs which are using braces ?

@Ocramius

Copy link
Copy Markdown
Contributor

@stof you'll have to be more specific about that, I fear. Perhaps issue outlining the potential problem?

@stof

stof commented Jan 21, 2021

Copy link
Copy Markdown

The support for alpine is "added" here by skipping the GLOB_BRACE constant. But this means that any glob pattern which actually uses braces (and so justify passing GLOB_BRACE to enable support for them) won't work on alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLOB_BRACE not defined in Alpine

3 participants