Bugfix: Fix emulation error of lstm by 'backward' and 'both' direction options - #802
Merged
Merged
Conversation
BruceDai
force-pushed
the
fix_lstm_emulation
branch
from
January 14, 2025 09:31
951402b to
223ea36
Compare
BruceDai
force-pushed
the
fix_lstm_emulation
branch
from
January 14, 2025 09:33
223ea36 to
88a35ff
Compare
huningxin
approved these changes
Jan 15, 2025
huningxin
left a comment
Contributor
There was a problem hiding this comment.
LGTM with comments about format.
/cc @philloooo
Contributor
Author
|
@philloooo Gentle ping, PTAL, thanks! |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix lstm emulation error of #801.
@fdwr @huningxin PTAL, thanks!
Preview | Diff