fix(vitest): ensure restoring terminal cursor on close - #5292
Merged
sheremet-va merged 1 commit intoMar 14, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--typecheckin run mode #5247I couldn't identify the actual cause of cursor not getting back only on typecheck run, so I went with using
logUpdate.doneto explicitly restore the cursor. There could be some deeper bug specific to typecheck run, but I couldn't see anything suspicious.additional notes
log-updateis used only for reporters such asdotanddefaultreporters on TTY, so the bug doesn't occur when using--reporter=tapfor example.log-updateinternally uses cli-cursor, which in turn uses restore-cursor. Since we haven't usedlogUpdate.done, probably we're relying onrestore-cursor's automatic restoration, which somehow doesn't work ontypecheckmode.test
pnpm -C examples/typecheck test:runPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.