fix(ui): auto reload coverage iframe after test run - #5242
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I tested a simple iframe reloading and tested by
pnpm -C examples/basic test:ui --coverage:Show demo
2024-02-20.13-35-10.webm
But actually I'm worrying that there might be some race condition here:
vitest/packages/vitest/src/node/core.ts
Lines 529 to 530 in a479115
If
reportCoveragetakes significant time, then reloading iframe duringonFinishedmight end up fetching old coverage html.To avoid this race condition, it might be necessary to either:
onReportCoverageFinished) just for this, orreportCoveragebeforeonFinished(this would likely mess up terminal output for coveragetextreporter) orI'm leaning towards the 1st option, but what do you think?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.