Improve PR builder by ThaminduDilshan · Pull Request #4181 · thunder-id/thunderid

ThaminduDilshan · 2026-07-20T18:21:22Z

Purpose

This pull request introduces several improvements to the CI workflows, focusing on caching and better separation of linting jobs. The main highlights are enhanced caching for dependencies and splitting frontend/backend linting for more granular feedback and performance.

Approach

CI Workflow Improvements:

Added caching for Go modules and Playwright browsers to speed up CI runs and reduce redundant downloads (.github/workflows/pr-builder.yml, .github/actions/setup-playwright/action.yml)
Split the lint job into lint-backend and lint-frontend for clearer separation and potentially faster feedback (.github/workflows/pr-builder.yml)

Frontend Build Consistency:

Standardized frontend build steps to use pnpm build:packages from the frontend directory for all relevant jobs, improving consistency and reliability (.github/workflows/pr-builder.yml)

Related Issues

N/A

Related PRs

N/A

Checklist

Security checks

Followed secure coding standards in WSO2 Secure Coding Guidelines
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Summary by CodeRabbit

Chores
- Improved Playwright and Go dependency caching to speed up automated checks.
- Standardized Node.js and pnpm setup across workflows.
- Split linting into dedicated backend and frontend checks.
- Updated frontend validation and end-to-end workflows to build shared packages more efficiently.
- Added clearer frontend formatting, linting, and package build verification.

coderabbitai · 2026-07-20T18:21:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 529b70ee-35fe-4ce6-b081-91d4625229c1

📥 Commits

Reviewing files that changed from the base of the PR and between a7d9f82 and e95e11c.

📒 Files selected for processing (3)

.github/actions/setup-playwright/action.yml
.github/actions/setup-pnpm/action.yml
.github/workflows/pr-builder.yml

🚧 Files skipped from review as they are similar to previous changes (3)

.github/actions/setup-playwright/action.yml
.github/actions/setup-pnpm/action.yml
.github/workflows/pr-builder.yml

📝 Walkthrough

Walkthrough

CI setup now caches Playwright and Go artifacts, separates backend and frontend linting, builds frontend packages in affected jobs, and centralizes pnpm and Node.js setup.

Changes

CI maintenance

Layer / File(s)	Summary
Playwright cache and installation flow `.github/actions/setup-playwright/action.yml`	Playwright browser artifacts are cached, with installation commands selected based on cache status.
Shared package manager setup `.github/actions/setup-pnpm/action.yml`, `.github/workflows/pr-builder.yml`	The shared pnpm action configures pnpm before the local Node.js setup action, and the E2E job adopts it.
Workflow validation and build updates `.github/workflows/pr-builder.yml`	Go module caching is added, linting is split into backend and frontend jobs, and frontend checks build packages instead of applications.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is concise but too generic to clearly describe the main CI workflow changes.	Use a more specific title that names the primary change, such as caching and lint job split in PR builder.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description matches the template well and includes purpose, approach, related items, checklist, and security checks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-20T19:04:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR improves the PR-builder CI workflow by adding dependency caching, splitting linting into backend/frontend jobs for clearer feedback, and standardizing frontend build steps used across jobs.

Changes:

Added caching for Go modules (actions/cache) in relevant Go jobs and introduced Playwright browser caching in the composite setup action.
Split linting into separate lint-backend and lint-frontend jobs for more granular reporting and shorter timeouts.
Standardized various frontend CI jobs to build via pnpm build:packages from the frontend/ workspace.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File	Description
build.sh	Removes a stray blank/whitespace-only line in the integration test function.
build.ps1	Removes a stray blank/whitespace-only line in the integration test function.
.github/workflows/pr-builder.yml	Adds Go module caching, splits lint jobs, and standardizes frontend build steps for CI jobs.
.github/actions/setup-playwright/action.yml	Adds Playwright browser caching and adjusts install behavior based on cache hits.

+      - name: �️ Cache Go Modules
+        uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4


+      - name: �🔧 Install Mockery
        run: make install-mockery


+      run: |
+        if [ "${{ steps.playwright-cache.outputs.cache-hit }}" = "true" ]; then
+          pnpm exec playwright install-deps ${{ inputs.browsers }}
+        else
+          pnpm exec playwright install --with-deps ${{ inputs.browsers }}
+        fi


Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

.github/workflows/pr-builder.yml:81

This step name contains a Unicode replacement character (�), which usually indicates a broken/incorrect file encoding. Replace it with the intended emoji (or plain text) so the workflow UI renders correctly.

      - name: �️ Cache Go Modules

.github/workflows/pr-builder.yml:91

This step name contains a Unicode replacement character (�), which usually indicates a broken/incorrect file encoding. Replace it with the intended emoji (or plain text) so the workflow UI renders correctly.

      - name: �🔧 Install Mockery

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

+      - name: ⚙️ Set up Node.js and pnpm
+        uses: ./.github/actions/setup-pnpm
        with:
-          run_install: false
-          cache_dependency_path: pnpm-lock.yaml
-          version: ${{ env.PNPM_VERSION }}
+          node-version: ${{ env.NODE_VERSION }}


ThaminduDilshan added the skip-changelog Skip generating changelog for a particular PR label Jul 20, 2026

ThaminduDilshan force-pushed the thamindu-build branch from 2b71479 to f14f4b4 Compare July 21, 2026 07:50

Copilot AI review requested due to automatic review settings July 21, 2026 07:50

ThaminduDilshan force-pushed the thamindu-build branch from f14f4b4 to 89851ec Compare July 21, 2026 07:51

Copilot started reviewing on behalf of ThaminduDilshan July 21, 2026 07:55 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 21, 2026 12:13

ThaminduDilshan force-pushed the thamindu-build branch from 89851ec to a7d9f82 Compare July 21, 2026 12:13

Copilot started reviewing on behalf of ThaminduDilshan July 21, 2026 12:16 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Improve pr build pipeline

e95e11c

Copilot AI review requested due to automatic review settings July 21, 2026 13:16

ThaminduDilshan force-pushed the thamindu-build branch from a7d9f82 to e95e11c Compare July 21, 2026 13:16

Copilot started reviewing on behalf of ThaminduDilshan July 21, 2026 13:17 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread .github/workflows/pr-builder.yml

Comment on lines +654 to +657

- name: ⚙️ Set up Node.js and pnpm

uses: ./.github/actions/setup-pnpm

with:

run_install: false

cache_dependency_path: pnpm-lock.yaml

version: ${{ env.PNPM_VERSION }}

node-version: ${{ env.NODE_VERSION }}

KaveeshaPiumini approved these changes Jul 22, 2026

View reviewed changes

This was referenced Jul 23, 2026

Speed up PR builder with pnpm/turbo caching, job consolidation, and parallel E2E workers #4269

Merged

Gate PR Builder on the trigger-pr-builder label as a temporary workaround #4292

Merged

ThaminduDilshan closed this Jul 23, 2026

This was referenced Jul 24, 2026

Improve pr builder #4319

Merged

Improve pr builder around playwright tests and product build #4339

Merged

[Draft] Improve PR builder #4340

Closed

Stop the pnpm store and Turbo caches from freezing at their first write #4427

Merged

ThaminduDilshan deleted the thamindu-build branch August 13, 2026 05:05

Navigation Menu

Uh oh!

Improve PR builder - #4181

Improve PR builder#4181
ThaminduDilshan wants to merge 1 commit into
thunder-id:mainfrom
ThaminduDilshan:thamindu-build

ThaminduDilshan commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Review ran into problems

Uh oh!

codecov Bot commented Jul 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		- name: �️ Cache Go Modules
		uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4

Uh oh!

Conversation

ThaminduDilshan commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Approach

Related Issues

Related PRs

Checklist

Security checks

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 inconclusive)

Review ran into problems

Uh oh!

codecov Bot commented Jul 20, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ThaminduDilshan commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading