Repository navigation
Replaced Guzzle dependency with native HttpHelper::class - #3054
Open
sanjana4khan wants to merge 16 commits into
Open
sanjana4khan wants to merge 16 commits into
sanjana4khan wants to merge 16 commits into
Conversation
harunollyo
requested changes
Oct 2, 2026
sanjana4khan
marked this pull request as draft
October 2, 2026 05:45
sanjana4khan
marked this pull request as ready for review
October 5, 2026 04:09
wp_remote_request()HttpHelper::class
harunollyo
requested changes
Oct 5, 2026
harunollyo
requested changes
Oct 5, 2026
harunollyo
requested changes
Oct 5, 2026
| return $response; | ||
| } | ||
|
|
||
| return json_decode( (string) $response->get_body() ); |
Collaborator
There was a problem hiding this comment.
Can we use $response->get_json() ?
harunollyo
requested changes
Oct 7, 2026
| @@ -101,45 +101,58 @@ private function parse_response( $response ) { | |||
| /** | |||
Collaborator
There was a problem hiding this comment.
Write a HttpHelperTest.php for unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.