[6.4🍒][Compile Time Constant Extraction] Add support for extracting function calls on instances#90058
Open
quinntaylor wants to merge 5 commits into
Open
[6.4🍒][Compile Time Constant Extraction] Add support for extracting function calls on instances#90058quinntaylor wants to merge 5 commits into
quinntaylor wants to merge 5 commits into
Conversation
Contributor
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for representing extracted function calls on instances. Previously they were incorrectly represented as
StaticFunctionCall, but this addsMemberFunctionCalland correct extraction.Impacts the JSON produced with
-emit-const-values-pathfor extracting constant values.rdar://180047264
[Compile Time Constant Extraction] Add support for extracting function calls on instances #87990
Low
In addition to the tests in this PR, this change has been validated with manual and automated tests in clients that consume the extracted JSON.
@artemcm, @jPaolantonio