Add missing TypeScript version to Admin Panel API code example#2372
Conversation
Adding related type
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thank you, @oktapodia!
Ideally, we should have JavaScript and TypeScript tabs anywhere in the docs, and indeed it seems this page does not have it yet.
- Would you mind updating your PR with this in mind?
Here's how JS/TS tabs should be handled in our Docusaurus instance:
<Tabs groupId="js-ts">
<TabItem value="js" label="JavaScript">
JS code block goes here
</TabItem>
<TabItem value="ts" label="TypeScript">
TS code block goes here
</TabItem>
<Tabs>
The groupId and value properties should be left as in my example so Docusaurus will remember the user's choice and tabs will stay in sync across all pages.
- Additionnally, would you mind going the extra mile and adding JS/TS tabs for all examples on this page? It would be greatly appreciated 🙏 but if too much work for you I'll add it to my backlog.
pwizla
left a comment
There was a problem hiding this comment.
Thanks.
Missed codeblocks quotes, I fixed them for you
|
@pwizla sorry I missed your comments, but are you sure about this? |
|
Thanks for following up, @oktapodia. I fixed it on the |
Adding related type
What does it do?
Adding the missing typescript type to the documentation
Why is it needed?
Avoid taking a couple of minutes to find the right type across strapi code
Related issue(s)/PR(s)