Skip to content

issue #210: bug: a.Mod(b) returns a negative number - Solved - #215

Closed
ashkanlarni wants to merge 2 commits into
shopspring:masterfrom
ashkanlarni:master
Closed

issue #210: bug: a.Mod(b) returns a negative number - Solved#215
ashkanlarni wants to merge 2 commits into
shopspring:masterfrom
ashkanlarni:master

Conversation

@ashkanlarni

Copy link
Copy Markdown

No description provided.

@mwoss

mwoss commented Feb 14, 2021

Copy link
Copy Markdown
Member

I see your implementation is failing on negative cases (-7.5 mod 2 and -7.5 mod -2. Mod implementation should return 0.5 and -1.5. (current implementation was incorrectly calculating -7.5 mod 2 tho

@mwoss

mwoss commented Jan 12, 2024

Copy link
Copy Markdown
Member

This issue has been already solved in #258 and #317. Closing.

@mwoss mwoss closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants