Run rustfmt on everything - #357
Conversation
| data: NodeData::Text { ref contents }, | ||
| .. | ||
| }) = previous() | ||
| { |
There was a problem hiding this comment.
I'm not happy about the placement of some of the opening brackets, like the one here. Maybe I could manually adjust these cases.
|
|
||
| fn get_template_contents(&mut self, target: &usize) -> usize { | ||
| if let Some(expanded_name!(html "template")) = self.names.get(&target).map(|n| n.expanded()) { | ||
| if let Some(expanded_name!(html "template")) = self.names.get(&target).map(|n| n.expanded()) |
There was a problem hiding this comment.
The call chain could probably be broken up into separate lines.
|
I don't think we should merge this PR if we don't enforce the same rules as servo/servo with the same settings. |
70cbb88 to
822acf5
Compare
|
@nox Oh, I missed that Servo has its own rusfmt config. I've added it to this project and rerun the formatter. What do you think? |
|
@bors-servo r+ |
|
📌 Commit 822acf5 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #347) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@mandreyel It seems some updates broke this PR, would you like to retry this? |
|
@Ygg01 Yes, sorry, I was a bit busy and forgot about this. I'll get to it tonight or tomorrow. |
|
Oh, no problem, I'm sorry you waited as long as you did. |
822acf5 to
12b4ce0
Compare
|
Alright, done :) |
|
@bors-servo r+ |
|
📌 Commit 12b4ce0 has been approved by |
Run rustfmt on everything I was reading through the code and noticed that the formatting was different from what I understand to be the currently agreed upon convention. So I ran rustfmt on the entire repo. I hope that's welcome, it made reading the code more pleasant. Tests run as previously.
|
☀️ Test successful - status-travis |
I was reading through the code and noticed that the formatting was different from what I understand to be the currently agreed upon convention. So I ran rustfmt on the entire repo. I hope that's welcome, it made reading the code more pleasant. Tests run as previously.