Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Ability to static compile VCR libs - #201

Merged
mgreter merged 2 commits into
masterfrom
build/win/gh-199
Dec 15, 2016
Merged

Ability to static compile VCR libs#201
mgreter merged 2 commits into
masterfrom
build/win/gh-199

Conversation

@am11

@am11 am11 commented Dec 11, 2016

Copy link
Copy Markdown
Contributor

Add more configurations to static compile VCR libs.

Also:

  • simplified the whole configuration matrix logic in sassc.vcxproj (bitness x configuration)
  • updated the docs accordingly
  • added .SolutionItems in sassc.sln and linked several repo files (.gitignore, README.md etc.) and docs directory.

Fix #199

@am11
am11 requested review from mgreter and nschonni December 11, 2016 16:19
@am11

am11 commented Dec 11, 2016

Copy link
Copy Markdown
Contributor Author

@altbdoor, thanks for the confirmation in issue. Can you please test out these changes? I have updated the docs accordingly as well. You can see the diff or browse the docs here: https://github.com/sass/sassc/blob/build/win/gh-199/docs/building/windows-instructions.md

Added @mgreter, @nschonni for the review.

Also added docs and other repo files in `.SolutionItems` (to make them
visible in VS' Solution Explorer)
@altbdoor

Copy link
Copy Markdown

@am11, I tested it out by building with /p:Configuration=Release /p:Platform=Win32, and I was able to get a static sassc.exe which worked in computers without the redistributable.

/p:Platform is a nice addition as well, thanks!

@am11 am11 changed the title Build/win/gh 199 Ability to static compile VCR libs Dec 12, 2016

@mgreter mgreter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgreter
mgreter merged commit 19d97ea into master Dec 15, 2016
@xzyfer
xzyfer deleted the build/win/gh-199 branch December 15, 2016 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants