feat: modernize library - #33
Merged
Merged
Conversation
shyim
force-pushed
the
modernize-package
branch
from
September 3, 2024 06:58
b05eeb1 to
8773e0e
Compare
shyim
marked this pull request as ready for review
September 3, 2024 07:10
Contributor
Author
|
@rezigned This is ready 😅 |
rezigned
reviewed
Sep 4, 2024
| ->setFinder( | ||
| (new Finder()) | ||
| ->in([__DIR__ . '/src', __DIR__ . '/tests']) | ||
| ); No newline at end of file |
rezigned
reviewed
Sep 4, 2024
| level: 5 | ||
| paths: | ||
| - src | ||
| - tests No newline at end of file |
rezigned
approved these changes
Sep 4, 2024
rezigned
left a comment
Member
There was a problem hiding this comment.
All goods and thank you for the help! 👍 (now the question is how should we version this 😅)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.