fix: esm issue in exports object - #86
Merged
Merged
Conversation
kanadgupta
requested review from
a team,
Dashron,
domharrington and
erunion
and removed request for
a team and
erunion
September 20, 2023 15:48
domharrington
approved these changes
Sep 20, 2023
domharrington
left a comment
Member
There was a problem hiding this comment.
Dont fully understand but LGTM!
This was referenced Sep 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Fixes an issue where we're incorrectly pointing to the CJS types for both the ESM and CJS exports. Instead we should be able to remove the
typesdefinition entirely and rely on the inferred types.This was instigated by the following TS error when performing an ESM migration on another package that depends on this:
🧬 QA & Testing
The current version of this package yields this on Are The Types Wrong:
When testing against the changes, it yields this: