feat(test): moving unit testing over to vitest - #789
Merged
Conversation
erunion
commented
Aug 9, 2023
| @@ -1,5 +1,7 @@ | |||
| import type { OASDocument } from '../../src/rmoas.types'; | |||
|
|
|||
| import { describe, beforeAll, it, expect } from 'vitest'; | |||
Member
Author
There was a problem hiding this comment.
Vitest offers a globals option1 for automatically adding these methods to every unit test but I kind of prefer the explicitness of not doing that.
Footnotes
kanadgupta
approved these changes
Aug 10, 2023
kanadgupta
left a comment
Contributor
There was a problem hiding this comment.
couple minor comments below but LGTM overall! absolutely obsessed with the fact that there's no config file
| "prepack": "npm run build", | ||
| "prepare": "husky install", | ||
| "pretest": "npm run lint", | ||
| "prettier": "prettier --list-different \"./**/**.{js,ts,md}\"", |
Contributor
There was a problem hiding this comment.
doesn't have to happen in this PR but thoughts on running prettier against everything?
Member
Author
There was a problem hiding this comment.
i think this is already doing that? we don't have any yaml files in here for testing flows
Contributor
There was a problem hiding this comment.
looks like prettier is flagging a few other files:
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Vitest is fast as hell and drops our unit test execution time down by a crazy amount.
Before
Now