Skip to content
This repository was archived by the owner on Oct 6, 2023. It is now read-only.

refactor: use lodash-es over lodash - #242

Merged
kanadgupta merged 1 commit into
mainfrom
refactor/use-lodash-es
Sep 21, 2023
Merged

refactor: use lodash-es over lodash#242
kanadgupta merged 1 commit into
mainfrom
refactor/use-lodash-es

Conversation

@kanadgupta

@kanadgupta kanadgupta commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

🧰 Changes

Fixes an issue I saw when attempting to bump this package dep in readmeio/api#735:

image

🧬 QA & Testing

This project is ESM already so I think this should be a patch change. If tests pass then I think we should be good to go!

@kanadgupta kanadgupta added dependencies Pull requests that update a dependency file refactor Issues about tackling technical debt labels Sep 21, 2023
@kanadgupta
kanadgupta marked this pull request as ready for review September 21, 2023 18:42
@kanadgupta
kanadgupta merged commit a10197a into main Sep 21, 2023
@kanadgupta
kanadgupta deleted the refactor/use-lodash-es branch September 21, 2023 18:43
Comment thread .eslintrc
"unicorn/prefer-node-protocol": "error",

"you-dont-need-lodash-underscore/get": "off",
"you-dont-need-lodash-underscore/set": "off"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rule doesn't exist!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file refactor Issues about tackling technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant