feat: avoid modifying the response object when calling response.text() - #854
Merged
kanadgupta merged 3 commits intoFeb 12, 2024
Merged
feat: avoid modifying the response object when calling response.text()#854kanadgupta merged 3 commits into
kanadgupta merged 3 commits into
Conversation
kanadgupta
suggested changes
Feb 12, 2024
Contributor
There was a problem hiding this comment.
hi there! thanks for this change, it looks great. could you add a test? this is the file you'll want to add your test(s) to: https://github.com/readmeio/api/blob/main/packages/core/test/lib/parseResponse.test.ts
let us know if you need a hand, thanks!
Contributor
Author
|
Hello @kanadgupta , test added! |
kanadgupta
approved these changes
Feb 12, 2024
kanadgupta
left a comment
Contributor
There was a problem hiding this comment.
thanks so much again @franciscopantojag!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃О Changes
response.text(). This can be helpful if we want to consume the response in a different way, likeresponse.arrayBuffer()when working with files馃К QA & Testing