feat: tsconfig, gitignore, npm script enhancements - #782
Merged
kanadgupta merged 9 commits intoOct 25, 2023
Conversation
kanadgupta
marked this pull request as ready for review
October 25, 2023 17:54
erunion
reviewed
Oct 25, 2023
Comment on lines
2
to
+7
| "compilerOptions": { | ||
| "module": "NodeNext", | ||
| "resolveJsonModule": true | ||
| "esModuleInterop": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "Bundler", | ||
| "resolveJsonModule": true, | ||
| "strict": true |
Member
There was a problem hiding this comment.
is attw still happy with these changes?
Contributor
Author
There was a problem hiding this comment.
good reminder, i hadn't checked that — but yes!
erunion
approved these changes
Oct 25, 2023
kanadgupta
deleted the
kanad/rm-8189-look-into-using-esnext-etc-for-tsconfigjson
branch
October 25, 2023 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Makes a few enhancements in the codegen'd SDK directory:
tsconfig.jsonto better match what's going on (this cheatsheet has been very helpful).gitignorefile that ignores thedist/directory since that directory is being autogenerated on a regular basis with thepreparenpm scriptlintnpm script so the user can typecheck their SDK if needed.🧬 QA & Testing
I confirmed that the SDK changes work well in my sandbox!