fix(httpsnippet-client-api): retain casing for non-reserved headers - #768
Merged
Conversation
erunion
marked this pull request as ready for review
October 18, 2023 21:17
erunion
commented
Oct 18, 2023
| value: 'Bar', | ||
| }, | ||
| { | ||
| name: 'X-Bar', |
Member
Author
There was a problem hiding this comment.
Changed this casing because X-Bar doesn't exist in the spec for this dataset and how we construct HAR objects in the API Explorer we won't ever translate x-bar to X-Bar (because X-Bar isn't in the spec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃О Changes
This fixes a quirk in
httpsnippet-client-apiwhere even though HTTP headers are case-insensitive the TS types we generate forapiare not and we are currently lowercasing all non-reserved header names we add into code snippets.