feat(httpsnippet-client-api): updates for v7 compatibility + custom variable support - #767
Merged
Conversation
erunion
marked this pull request as ready for review
October 18, 2023 18:06
| * @note This function also exists in `api/fetcher`. | ||
| */ | ||
| function getProjectPrefixFromRegistryUUID(uri: string) { | ||
| const matches = uri.match(registryUUIDRegex); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
kanadgupta
reviewed
Oct 18, 2023
kanadgupta
left a comment
Contributor
There was a problem hiding this comment.
i don't see any changes related to this installation step:
does that happen in another repo?
Member
Author
|
@kanadgupta Yeah that's part of I still need to update that library to support dual exports and will update the install step then. |
kanadgupta
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃О Changes
require('api')('...')accessor.sdk).requireover toimportbecause 2023, and also codegen now supports CJS and ESM.