Skip to content

refactor: remove make-dir as a dep - #746

Merged
erunion merged 2 commits into
mainfrom
kanad/rm-8049-remove-make-dir-dependency
Oct 6, 2023
Merged

refactor: remove make-dir as a dep#746
erunion merged 2 commits into
mainfrom
kanad/rm-8049-remove-make-dir-dependency

Conversation

@kanadgupta

@kanadgupta kanadgupta commented Sep 28, 2023 •
edited by erunion
Loading

Copy link
Copy Markdown
Contributor

馃О Changes

make-dir isn't needed a we can call fs.makeDirSync instead.

@erunion
erunion marked this pull request as ready for review October 6, 2023 17:31
@erunion erunion added the refactor Issues about tackling technical debt label Oct 6, 2023
@erunion
erunion merged commit ab41a72 into main Oct 6, 2023
@erunion
erunion deleted the kanad/rm-8049-remove-make-dir-dependency branch October 6, 2023 17:32
@kanadgupta

kanadgupta commented Oct 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@erunion the fs return value is slightly different from make-dir鈥檚 (I think one includes the full path and one is only the directory name itself) and it鈥檚 not tested so we might need to do a bit of additional validation here 馃珷

@erunion erunion mentioned this pull request Oct 6, 2023
Merged
@erunion erunion added this to the v7 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erunion erunion erunion approved these changes

Assignees

No one assigned

Labels

refactor Issues about tackling technical debt

Projects

None yet

Milestone

v7

Development

Successfully merging this pull request may close these issues.

2 participants

@kanadgupta @erunion