Skip to content

Added phpunit to the dev requirements. Fixed test cases to no longer … - #45

Closed
SamMousa wants to merge 1 commit into
reactphp:masterfrom
SamMousa:fix-deprecated-getmock
Closed

Added phpunit to the dev requirements. Fixed test cases to no longer …#45
SamMousa wants to merge 1 commit into
reactphp:masterfrom
SamMousa:fix-deprecated-getmock

Conversation

@SamMousa

Copy link
Copy Markdown

…use deprecated getMock function.

@SamMousa

Copy link
Copy Markdown
Author

Have changed / partially reverted this to instead require PHPUnit 4.8

@clue

clue commented Jul 13, 2016

Copy link
Copy Markdown
Member

Personally, I'm undecided on this, but I know similar patches have been rejected in the past.

I guess this worth discussing in the meta repo?

@SamMousa

Copy link
Copy Markdown
Author

@clue What do you mean, you don't think we should use require-dev?

I tried to run tests having installed phpunit 5 locally and they failed; how would I find out what version of PHPUnit I should use if it's not in require-dev?

@clue

clue commented Jul 13, 2016

Copy link
Copy Markdown
Member

I think there are valid reasons both pro and contra adding require-dev and you've listed a very valid reason pro imho. I would suggest discussing this in the main meta repo instead, because this does not apply to this component alone.

@clue

clue commented Jan 14, 2017

Copy link
Copy Markdown
Member

Closed via #57

@clue clue closed this Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants