Skip to content

Forward compatibility with PHPUnit v5 - #122

Merged
WyriHaximus merged 1 commit into
reactphp:masterfrom
andig:test
Oct 7, 2017
Merged

Forward compatibility with PHPUnit v5#122
WyriHaximus merged 1 commit into
reactphp:masterfrom
andig:test

Conversation

@andig

@andig andig commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

Gets rid of the warnings and speeds up testing some.

Builds on top of #57

@WyriHaximus WyriHaximus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@clue clue changed the title Fix test deprecations Forward compatibility with PHPUnit v5 Oct 7, 2017

@clue clue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filing this! I've amended your changes to also update the PHPUnit version in the composer.json, now let's get this in! :shipit:

@WyriHaximus
WyriHaximus merged commit 5deb19b into reactphp:master Oct 7, 2017
@andig
andig deleted the test branch October 7, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants