Skip to content

clean up some duplicated code related to TickQueue - #28

Closed
drealecs wants to merge 1 commit into
reactphp:masterfrom
drealecs:small_fix
Closed

clean up some duplicated code related to TickQueue#28
drealecs wants to merge 1 commit into
reactphp:masterfrom
drealecs:small_fix

Conversation

@drealecs

Copy link
Copy Markdown

No description provided.

@cboden

cboden commented Apr 21, 2015

Copy link
Copy Markdown
Member

nextTick and futureTick have different functionality.

@drealecs

Copy link
Copy Markdown
Author

Yes, the objects have different purpose. However, the implementation is the same...

@daltones

Copy link
Copy Markdown

Have a look at method tick. Different functionality AND implementation. Maybe you didn't understand the difference.

@drealecs

Copy link
Copy Markdown
Author

Indeed, now I see it. Sorry for your time. I'll just close this now...

@drealecs drealecs closed this Apr 21, 2015
@drealecs

Copy link
Copy Markdown
Author

The documentation might not be clear enough or maybe it was just me.
If we're here, we might as well try to figure it out why I was confused with the implementation interface (excepting the fact that I didn't pay attention to the implementation).

Is there any contract regarding calling nextTick from a callback that was scheduled with a futureTick? Because callbacks registered this way will be executed after the timers and this is not expected as declared in the documentation.

Is there any contract regarding calling futureTick from a callback that was scheduled with a nextTick? Because callbacks registered this way will be executed before any timers and this might not be expected.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants