fix: avoid crash on iOS 14 when push comes on foreground - #234
Merged
Conversation
bang9
marked this pull request as draft
November 13, 2020 20:52
bang9
marked this pull request as ready for review
November 13, 2020 21:03
Author
|
If you use PushNotification.configure({
onNotification: (notification) => {
// do not call finish
// notification.finish(PushNotificationIOS.FetchResult.NoData);
}
}) |
|
It will make to avoid the crash, but Push notifications doesn't work in foreground. |
Naturalclar
approved these changes
Nov 22, 2020
Naturalclar
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I'm not able to reproduce the crash for my use, so I'll publish new package with this fix as beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
may resolve #163
related issues
invertase/react-native-firebase#3944
firebase/firebase-ios-sdk#6863