Skip to content

fix: group users listing should only have members#399

Merged
kushsharma merged 1 commit into
mainfrom
group-users-listing
Oct 25, 2023
Merged

fix: group users listing should only have members#399
kushsharma merged 1 commit into
mainfrom
group-users-listing

Conversation

@kushsharma

@kushsharma kushsharma commented Oct 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • currently listing group users returns all the users who have access to the group
  • ideally it should only return users who were explicitly added as owner or member of the group
  • same goes for listing project users

@vercel

vercel Bot commented Oct 24, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:33am

@kushsharma kushsharma marked this pull request as ready for review October 24, 2023 16:37
@coveralls

coveralls commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6635508675

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.275%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/serve.go 0 1 0.0%
Totals Coverage Status
Change from base Build 6604461191: 0.0%
Covered Lines: 5768
Relevant Lines: 11473
💛 - Coveralls

@kushsharma
fix: group users listing should only have members
ad1b8b5 
- currently listing group users returns all the users who
have access to the group
- ideally it should only return users who were explicitly added
as owner or member of the group
- same has been modified for project user listing as well

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma merged commit 289f7c5 into main Oct 25, 2023
@kushsharma kushsharma deleted the group-users-listing branch October 25, 2023 04:40
@whoAbhishekSah whoAbhishekSah mentioned this pull request Jun 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kushsharma @coveralls