Replace XLA_COUNTER with TORCH_LAZY_COUNTER - #4208
Merged
Merged
Conversation
alanwaketan
marked this pull request as draft
November 17, 2022 03:52
alanwaketan
marked this pull request as ready for review
November 17, 2022 06:10
Collaborator
Author
|
@JackCaoG Will the REMOVE_TORCH_PIN label remove the pin before merging? |
Collaborator
|
lol nope, it is just a reminder for yourself. you can delete the pin and merge without waiting for CI |
alanwaketan
force-pushed
the
alanwaketan/counters
branch
from
November 18, 2022 09:43
f22c12c to
9e2f343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request replaces most of XLA_COUNTER with the pytorch/xla lib with upstream TORCH_LAZY_COUNTER. However, XLA_COUNTER is still kept to be used in the xla_client lib.
Test Plan:
python test/test_metrics.py MetricsTest.test_metrics_report
and CI.