Skip to content

[Test] Port roi_align (CUDA) to stable ABI. - #9573

Draft
adabeyta wants to merge 1 commit into
mainfrom
adabeyta/roi-align-cuda-stable
Draft

[Test] Port roi_align (CUDA) to stable ABI.#9573
adabeyta wants to merge 1 commit into
mainfrom
adabeyta/roi-align-cuda-stable

Conversation

@adabeyta

Copy link
Copy Markdown
Collaborator

Ports roi_align CUDA/ROCm kernels to the stable ABI.

Notes

  • Requires [Stable ABI] Move fastAtomicAdd to torch/headeronly. pytorch#191501.
  • Determinism layer change: The CUDA backward's at::globalContext().alertNotDeterministic call can't be made from a stable kernel, so it moves to the Python backward as torch._prims_common.alert_not_deterministic, gated to grad_output.device.type == "cuda". The CPU backward remains unchanged .

Stable-ABI audit (torch-abi-audit)

Ran torch-abi-audit on a CUDA build. The counts don't move with this layer since the CUDA kernel's unstable references are all shared with the remaining legacy ops.

    Package: torchvision
      Torch ABI:   UNSTABLE
      CPython ABI: n/a
      Bundled libs: 3
      -- bundled libs --
        [UNSTABLE] [not-abi3] _C.so            (stable_shim=0,  unstable=103)
        [STABLE  ] [not-abi3] _C_stable.so     (stable_shim=70, unstable=0)
        [STABLE  ] [not-abi3] image_stable.so  (stable_shim=76, unstable=0)

@pytorch-bot

pytorch-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9573

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 24 New Failures, 1 Unrelated Failure, 1 Unclassified Failure

As of commit bf0a70a with merge base 0b23e88 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the cla signed label Jul 30, 2026
@adabeyta
adabeyta changed the base branch from main to adabeyta/roi-align-cpu-stable July 30, 2026 21:27
Base automatically changed from adabeyta/roi-align-cpu-stable to main August 4, 2026 19:05
@NicolasHug
NicolasHug force-pushed the adabeyta/roi-align-cuda-stable branch from c76604f to bf0a70a Compare August 4, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant