Add type hints to Jira plugin - #441
Merged
Merged
Conversation
sandrobonazzola
requested review from
kwk and
psss
and removed request for
kwk
November 18, 2025 10:23
kwk
reviewed
Nov 18, 2025
This commit adds comprehensive type annotations to the Jira plugin to improve code maintainability and enable better static type checking. Key changes: - Add type hints to all methods, parameters, and return types - Rename JiraStats class to JiraStatsGroup to avoid naming conflict - Introduce new JiraStats base class for all Jira stat classes - Change TIMEOUT constant from int to float (60.0) - Improve error handling: - Add connection aborted retry logic with 10s sleep - Handle 401 errors with session renewal - Change rate limit log messages from warning to debug level - Add type annotations to all test functions - Update test imports to use JiraStatsGroup This refactoring maintains backward compatibility while improving code quality and type safety. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
jira_types
branch
from
November 18, 2025 11:28
bb17af7 to
a95c1f4
Compare
kwk
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive type annotations to the Jira plugin to improve code maintainability and enable better static type checking.
Key changes:
This refactoring maintains backward compatibility while improving code quality and type safety.