Add unit tests for utils module - #417
Merged
Merged
Conversation
sandrobonazzola
force-pushed
the
test_utils
branch
from
July 8, 2025 11:55
884c885 to
592c749
Compare
- Removed useless assertions on class existance which could always be true in boolean context. - Created more useful unit tests for utils module. - Fixed typing issues while handling this. - Addressed a compatibility issue in google.py with Python3.9 discovered after typing has been added to utils.py. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
test_utils
branch
from
July 16, 2025 06:59
592c749 to
5f8cc9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed useless assertions on class existence which could always be true in boolean context.
Created more useful unit tests for utils module.
Fixed typing issues while handling this.
Addressed a compatibility issue in
google.pywith Python3.9 discovered after typing has been added toutils.py.