Fix return type for get_token in base.py - #412
Merged
Merged
Conversation
Collaborator
Author
|
Converting to draft as it fails on pytthon 3.9 with: ==================================== ERRORS ====================================
_____________________ ERROR collecting tests/test_base.py ______________________
tests/test_base.py:14: in <module>
import did.base
did/base.py:495: in <module>
token_file_key: str = "token_file") -> str | None:
E TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
______________________ ERROR collecting tests/test_cli.py ______________________
tests/test_cli.py:9: in <module>
import did.base
did/base.py:495: in <module>
token_file_key: str = "token_file") -> str | None:
E TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
_____________________ ERROR collecting tests/test_stats.py _____________________
tests/test_stats.py:3: in <module>
import did.stats
did/stats.py:8: in <module>
import did.base
did/base.py:495: in <module>
token_file_key: str = "token_file") -> str | None:
E TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' |
sandrobonazzola
marked this pull request as draft
June 18, 2025 16:20
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
get_token
branch
from
June 19, 2025 14:20
9474c72 to
eb26cd3
Compare
sandrobonazzola
marked this pull request as ready for review
June 19, 2025 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.