Skip to content

Fix return type for get_token in base.py - #412

Merged
sandrobonazzola merged 1 commit into
psss:mainfrom
sandrobonazzola:get_token
Jun 23, 2025
Merged

Fix return type for get_token in base.py#412
sandrobonazzola merged 1 commit into
psss:mainfrom
sandrobonazzola:get_token

Conversation

@sandrobonazzola

Copy link
Copy Markdown
Collaborator

No description provided.

@sandrobonazzola

Copy link
Copy Markdown
Collaborator Author

Converting to draft as it fails on pytthon 3.9 with:

==================================== ERRORS ====================================
_____________________ ERROR collecting tests/test_base.py ______________________
tests/test_base.py:14: in <module>
    import did.base
did/base.py:495: in <module>
    token_file_key: str = "token_file") -> str | None:
E   TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
______________________ ERROR collecting tests/test_cli.py ______________________
tests/test_cli.py:9: in <module>
    import did.base
did/base.py:495: in <module>
    token_file_key: str = "token_file") -> str | None:
E   TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
_____________________ ERROR collecting tests/test_stats.py _____________________
tests/test_stats.py:3: in <module>
    import did.stats
did/stats.py:8: in <module>
    import did.base
did/base.py:495: in <module>
    token_file_key: str = "token_file") -> str | None:
E   TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

@sandrobonazzola
sandrobonazzola marked this pull request as draft June 18, 2025 16:20
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@sandrobonazzola
sandrobonazzola marked this pull request as ready for review June 19, 2025 14:20
@sandrobonazzola
sandrobonazzola merged commit 166064d into psss:main Jun 23, 2025
@sandrobonazzola
sandrobonazzola deleted the get_token branch June 23, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant