Fix PageModified stat in Confluence plugin - #400
Merged
Conversation
sandrobonazzola
force-pushed
the
modified_pages
branch
from
June 4, 2025 07:36
c8bf8be to
45add52
Compare
Extracted `fetch_ratelimited_url` from `search` in order to avoid duplicated code and used it in the new method `get_page_versions`. Used this new method to ensure the page modified in the given time range have been really modified by the user and not just created by the user in the past but modified by someone else. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
modified_pages
branch
from
June 5, 2025 09:01
45add52 to
da5ceaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted
fetch_ratelimited_urlfromsearchin order to avoid duplicated code and used it in the new methodget_page_versions.Used this new method to ensure the page modified in the given time range have been really modified by the user and not just created by the user in the past but modified by someone else.