Skip to content

Merge changes from sandrobonazzola/did fork - #390

Merged
psss merged 147 commits into
psss:mainfrom
sandrobonazzola:main
May 19, 2025
Merged

Merge changes from sandrobonazzola/did fork#390
psss merged 147 commits into
psss:mainfrom
sandrobonazzola:main

Conversation

@sandrobonazzola

Copy link
Copy Markdown
Collaborator

Notable changes:

  • Collect stats in parallel
  • Handle Jira API ratelimit
  • Fixed several deprecation warning and pylint reported issues
  • Improved stability and error handling
  • Improved test coverage

Adding markdown format output to koji plugin.
In order to provide a link to the build, `weburl` option is required,
pointing to the koji web interface.
It's now possible to use token authentication for connecting to
Confluence. Page list is now also available in markdown format.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Recently Red Hat bugzilla SSL certificate is failing verification.
In order to allow querying bugzilla while this issue is getting fixed,
allowing to skip SSL certificate validation.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixing pylint warnings:
W1201: Use lazy % formatting in logging functions (logging-not-lazy)
W1202: Use lazy % or % formatting in logging functions (logging-format-interpolation)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixed:
W0707: Consider explicitly re-raising using ... (raise-missing-from)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixing:
R0205: Class inherits from object,
can be safely removed from bases in python3
(useless-object-inheritance)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixing W0622: Redefining built-in (redefined-builtin)
While doing it, removing the unused function utils.ascii
which was overriding the ascii built-in as the only place where it was
used was its test unit.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
W0107: Unnecessary pass statement (unnecessary-pass)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
W1406: The u prefix for strings is no longer necessary
in Python >=3.0 (redundant-u-string-prefix)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
W0611: Unused pformat imported from pprint as pretty (unused-import)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
W0104: Statement seems to have no effect (pointless-statement)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
DeprecationWarning: 'maxsplit' is passed as positional argument

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixing:
W3101: Missing timeout argument for method 'requests.get'
can cause your program to hang indefinitely (missing-timeout)

by adding an optional timeout config to the plugins using that method,
defaulting to 60 seconds if not set.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Use proper os.path.join dealing with paths and use f-string to make more
understandable the desired strings.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
R1724: Unnecessary "else" after "continue", remove the "else"
and de-indent the code inside it (no-else-continue)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
R1704: Redefining argument with the local name ... (redefined-argument-from-local)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Fixes:
R1734: Consider using [] instead of list() (use-list-literal)

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
- Added timeout support
- Added rate limit handling
- Reduced differences with jira plugin as preparation to refactoring

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
Added hyperkitty and public_inbox plugins to the docs.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
The query for github requesting to exclude an organization was badly
encoded.

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@psss

psss commented May 17, 2025

Copy link
Copy Markdown
Owner

@sandrobonazzola, thanks a lot for all these contributions! This is an incredible amount of work! Very nice improvements! I've merged a couple open pull requests before this large one:

Wanted mainly to prevent introducing an extra license because of the strtobool implementation. After some small adjustments I've rebased your changes and resolved conflicts. Didn't want to force-push to your main branch and thus created #395. Let's finish the review there.

@sandrobonazzola

Copy link
Copy Markdown
Collaborator Author

If it makes things easier feel free to force push to my fork. If you prefer to stay on #395 feel free to close this one.

@psss
psss merged commit 1f01317 into psss:main May 19, 2025
@psss psss self-assigned this May 19, 2025
@psss psss added this to the 0.22 milestone May 19, 2025
@psss

psss commented May 19, 2025

Copy link
Copy Markdown
Owner

Ok, thanks! Pushed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants