Drop usage of distutils - #355
Closed
sandrobonazzola wants to merge 1 commit into
Closed
Conversation
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
February 9, 2024 14:51
fa52009 to
09fc48b
Compare
lukaszachy
requested changes
Feb 9, 2024
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
February 12, 2024 07:16
09fc48b to
1843543
Compare
lukaszachy
approved these changes
Feb 12, 2024
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
May 2, 2024 07:51
1843543 to
93ed3e5
Compare
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
June 28, 2024 13:08
93ed3e5 to
31fb824
Compare
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
September 2, 2024 09:09
31fb824 to
6e57042
Compare
Replace `distutils.util.strtobool` with a local copy of the function following the [Migration advice](https://peps.python.org/pep-0632/#migration-advice) due to `distutils` module deprecation. Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
sandrobonazzola
force-pushed
the
distutil_removal
branch
from
October 7, 2024 06:35
6e57042 to
06da4c5
Compare
psss
added a commit
that referenced
this pull request
May 17, 2025
Let's implement a simple `strtobool()` function in `did.utils`. This replaces #355 as it does not make much sense to introduce a new license just because of such a basic functionality.
Owner
|
I don't think it's really worth it introducing an extra license just because of such a basic functionality. Let's do our custom simple implementation in #394. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
distutils.util.strtoboolwith a local copy of the function following theMigration advice due to
distutilsmodule deprecation.