Fix Zammad plugin by filtering tickets after search - #328
Merged
Conversation
psss
previously requested changes
Oct 2, 2023
Collaborator
Contributor
Author
sandrobonazzola
approved these changes
Jun 6, 2025
sandrobonazzola
left a comment
Collaborator
There was a problem hiding this comment.
The plugin itself would benefit of some additional exception handling but can be done in separate patch.
sandrobonazzola
dismissed
psss’s stale review
June 10, 2025 07:23
Requested changes have been provided, new review needed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Fixed flake8 complaints on line too long. While doing that, refactored a bit the loops avoiding to go through the various objects to get since and until values multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API query is not searching correctly and is returning more tickets that it should, so we loop on them and get articles from the API to filter which one were actually updated in the time range.
This reduces false positive a lot.