hack/ci: pass -r to limactl copy for directory copies - #29434
Merged
Luap99 merged 1 commit intoAug 12, 2026
Conversation
The 'limactl copy' calls in hack/ci/ci.sh copy directories (the repo dir into the VM, and the logs dir out of the VM). Depending on the underlying transport limactl uses (scp vs rsync), directory copies without -r may fail with 'is not a regular file'. This works in CI but breaks in local VMs. Fixes podman-container-tools#29425 Signed-off-by: Shreya Vidyadhar <shrevidh03@gmail.com>
Contributor
Honny1
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hack/ci/ci.shcallslimactl copytwice on directories — the repo directory being copied into the VM at line 30, and the logs directory being copied back out at line 40.limactl copyuses the underlying host transport (scp or rsync) and without-r,scprefuses a directory withis not a regular file, which matches what @mtrmac reported in #29425. It happens to work in CI (likely the rsync path) but breaks in local VMs (scp path).Small fix: add
-rto bothlimactl copydirectory calls so they're always recursive regardless of the underlying transport.Fixes #29425
Testing
Shell change only, no Go build affected. Local-VM reproducer requires an environment where limactl uses the scp transport — happy to iterate if @mtrmac or @timcoding1988 can confirm on the exact setup that failed.
Checklist
Fixes: #00000in commit message.make validatepr(could not run locally on macOS — relying on CI).Does this PR introduce a user-facing change?