Skip to content

Fixed #69017 Fail to push to array with constant value defined in class scope - #1077

Closed
reeze wants to merge 1 commit into
php:PHP-5.5from
reeze:bug-69017
Closed

reeze wants to merge 1 commit into
php:PHP-5.5from
reeze:bug-69017

Conversation

@reeze

@reeze reeze commented Feb 11, 2015

Copy link
Copy Markdown
Contributor

https://bugs.php.net/bug.php?id=69017

When updating constant key we should update nNextElement too.

… class scope

When updating constant key we should update nNextElement too.
@reeze

reeze commented Feb 11, 2015

Copy link
Copy Markdown
Contributor Author

5.5 & 5.4 have the same bug.

5.6 & master didn't have the bug because of different logic of _zval_copy_ctor_func() it didn't discover the problem, but it should be merged to 5.6 & master too.

@laruence

Copy link
Copy Markdown
Member

I got a better fix, committed in f2940b7 ,

and actually, 5.6 and master use different way handling such cases, nothing to do with zval_copy_ctor_func..

and for master, there is not update_current_key_ex at all

thanks

@reeze reeze closed this Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants