memory-get-usage.xml Clarify what kind of memory we are talking about#4491
Open
mmalferov wants to merge 2 commits into
Open
memory-get-usage.xml Clarify what kind of memory we are talking about#4491mmalferov wants to merge 2 commits into
mmalferov wants to merge 2 commits into
Conversation
The current description confuses the reader and does not explain who allocates memory to whom. I'm not sure about the accuracy of the proposed formulations, but it seems that the changes better explain the difference between function calls without arguments or with the value `false`, or with the argument `true`. I think that mentioning the engine, Zend Memory Manager (ZMM), or other internal details would be redundant, and the current description is enough to understand the difference. Please check the proposal and make corrections to eliminate linguistic or semantic inaccuracies, if any, in the updated text. And if the suggestion is OK, I will make the same changes with `memory_get_peak_usage()` ;-)
Crell
reviewed
Oct 3, 2025
Crell
reviewed
Oct 3, 2025
| Returns the amount of memory, in bytes, that's currently being | ||
| allocated to your PHP script. | ||
| Returns the amount of memory, in bytes, that the PHP script is | ||
| currently using. |
Contributor
There was a problem hiding this comment.
This is a subtle change in meaning. I'm not actually sure which is accurate. The script could be using X bytes, but the OS has given it access to X+Y bytes. (Especially if your script has cleaned up some memory.)
Can someone verify which value is measured here? Tagging @Girgias
Crell
reviewed
Oct 3, 2025
Comment on lines
-60
to
+63
| echo memory_get_usage() . "\n"; // 36640 | ||
| echo memory_get_usage(), "\n"; // 36640 |
Contributor
There was a problem hiding this comment.
These changes are stylistic, and I don't think necessary.
Co-authored-by: Larry Garfield <larry@garfieldtech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current description confuses the reader and does not explain who allocates memory to whom. I'm not sure about the accuracy of the proposed formulations, but it seems that the changes better explain the difference between function calls without arguments or with the value
false, or with the argumenttrue.I think that mentioning the engine, Zend Memory Manager (ZMM), or other internal details would be redundant, and the current description is enough to understand the difference.
Please check the proposal and make corrections to eliminate linguistic or semantic inaccuracies, if any, in the updated text.
And if the suggestion is OK, I will make the same changes with
memory_get_peak_usage();-)